Bug Summary

File:lib/algorithms/sign.c
Location:line 129, column 22
Description:Value stored to 'i' is never read

Annotated Source Code

1/*
2 * Copyright (C) 2011-2012 Free Software Foundation, Inc.
3 *
4 * Author: Nikos Mavrogiannopoulos
5 *
6 * This file is part of GnuTLS.
7 *
8 * The GnuTLS is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Lesser General Public License
10 * as published by the Free Software Foundation; either version 3 of
11 * the License, or (at your option) any later version.
12 *
13 * This library is distributed in the hope that it will be useful, but
14 * WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16 * Lesser General Public License for more details.
17 *
18 * You should have received a copy of the GNU Lesser General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>
20 *
21 */
22
23#include <gnutls_int.h>
24#include <algorithms.h>
25#include <gnutls_errors.h>
26#include <x509/common.h>
27
28/* signature algorithms;
29 */
30struct gnutls_sign_entry
31{
32 const char *name;
33 const char *oid;
34 gnutls_sign_algorithm_t id;
35 gnutls_pk_algorithm_t pk;
36 gnutls_digest_algorithm_t mac;
37 /* See RFC 5246 HashAlgorithm and SignatureAlgorithm
38 for values to use in aid struct. */
39 const sign_algorithm_st aid;
40};
41typedef struct gnutls_sign_entry gnutls_sign_entry;
42
43#define TLS_SIGN_AID_UNKNOWN{255, 255} {255, 255}
44static const sign_algorithm_st unknown_tls_aid = TLS_SIGN_AID_UNKNOWN{255, 255};
45
46static const gnutls_sign_entry sign_algorithms[] = {
47 {"RSA-SHA1", SIG_RSA_SHA1_OID"1.2.840.113549.1.1.5", GNUTLS_SIGN_RSA_SHA1, GNUTLS_PK_RSA,
48 GNUTLS_MAC_SHA1, {2, 1}},
49 {"RSA-SHA224", SIG_RSA_SHA224_OID"1.2.840.113549.1.1.14", GNUTLS_SIGN_RSA_SHA224, GNUTLS_PK_RSA,
50 GNUTLS_MAC_SHA224, {3, 1}},
51 {"RSA-SHA256", SIG_RSA_SHA256_OID"1.2.840.113549.1.1.11", GNUTLS_SIGN_RSA_SHA256, GNUTLS_PK_RSA,
52 GNUTLS_MAC_SHA256, {4, 1}},
53 {"RSA-SHA384", SIG_RSA_SHA384_OID"1.2.840.113549.1.1.12", GNUTLS_SIGN_RSA_SHA384, GNUTLS_PK_RSA,
54 GNUTLS_MAC_SHA384, {5, 1}},
55 {"RSA-SHA512", SIG_RSA_SHA512_OID"1.2.840.113549.1.1.13", GNUTLS_SIGN_RSA_SHA512, GNUTLS_PK_RSA,
56 GNUTLS_MAC_SHA512, {6, 1}},
57 {"RSA-RMD160", SIG_RSA_RMD160_OID"1.3.36.3.3.1.2", GNUTLS_SIGN_RSA_RMD160, GNUTLS_PK_RSA,
58 GNUTLS_MAC_RMD160, TLS_SIGN_AID_UNKNOWN{255, 255}},
59 {"DSA-SHA1", SIG_DSA_SHA1_OID"1.2.840.10040.4.3", GNUTLS_SIGN_DSA_SHA1, GNUTLS_PK_DSA,
60 GNUTLS_MAC_SHA1, {2, 2}},
61 {"DSA-SHA224", SIG_DSA_SHA224_OID"2.16.840.1.101.3.4.3.1", GNUTLS_SIGN_DSA_SHA224, GNUTLS_PK_DSA,
62 GNUTLS_MAC_SHA224, {3, 2}},
63 {"DSA-SHA256", SIG_DSA_SHA256_OID"2.16.840.1.101.3.4.3.2", GNUTLS_SIGN_DSA_SHA256, GNUTLS_PK_DSA,
64 GNUTLS_MAC_SHA256, {4, 2}},
65 {"RSA-MD5", SIG_RSA_MD5_OID"1.2.840.113549.1.1.4", GNUTLS_SIGN_RSA_MD5, GNUTLS_PK_RSA,
66 GNUTLS_MAC_MD5, {1, 1}},
67 {"RSA-MD2", SIG_RSA_MD2_OID"1.2.840.113549.1.1.2", GNUTLS_SIGN_RSA_MD2, GNUTLS_PK_RSA,
68 GNUTLS_MAC_MD2, TLS_SIGN_AID_UNKNOWN{255, 255}},
69 {"ECDSA-SHA1", "1.2.840.10045.4.1", GNUTLS_SIGN_ECDSA_SHA1, GNUTLS_PK_EC, GNUTLS_MAC_SHA1, {2, 3}},
70 {"ECDSA-SHA224", "1.2.840.10045.4.3.1", GNUTLS_SIGN_ECDSA_SHA224, GNUTLS_PK_EC, GNUTLS_MAC_SHA224, {3, 3}},
71 {"ECDSA-SHA256", "1.2.840.10045.4.3.2", GNUTLS_SIGN_ECDSA_SHA256, GNUTLS_PK_EC, GNUTLS_MAC_SHA256, {4, 3}},
72 {"ECDSA-SHA384", "1.2.840.10045.4.3.3", GNUTLS_SIGN_ECDSA_SHA384, GNUTLS_PK_EC, GNUTLS_MAC_SHA384, {5, 3}},
73 {"ECDSA-SHA512", "1.2.840.10045.4.3.4", GNUTLS_SIGN_ECDSA_SHA512, GNUTLS_PK_EC, GNUTLS_MAC_SHA512, {6, 3}},
74 {"GOST R 34.10-2001", SIG_GOST_R3410_2001_OID"1.2.643.2.2.3", 0, 0, 0,
75 TLS_SIGN_AID_UNKNOWN{255, 255}},
76 {"GOST R 34.10-94", SIG_GOST_R3410_94_OID"1.2.643.2.2.4", 0, 0, 0, TLS_SIGN_AID_UNKNOWN{255, 255}},
77 {0, 0, 0, 0, 0, TLS_SIGN_AID_UNKNOWN{255, 255}}
78};
79
80#define GNUTLS_SIGN_LOOP(b)do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { b ; } } while (0) \
81 do { \
82 const gnutls_sign_entry *p; \
83 for(p = sign_algorithms; p->name != NULL((void*)0); p++) { b ; } \
84 } while (0)
85
86#define GNUTLS_SIGN_ALG_LOOP(a)do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if(p->id && p->id ==
sign) { a; break; } ; } } while (0) \
87 GNUTLS_SIGN_LOOP( if(p->id && p->id == sign) { a; break; } )do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if(p->id && p->id ==
sign) { a; break; } ; } } while (0)
88
89/**
90 * gnutls_sign_get_name:
91 * @algorithm: is a sign algorithm
92 *
93 * Convert a #gnutls_sign_algorithm_t value to a string.
94 *
95 * Returns: a string that contains the name of the specified sign
96 * algorithm, or %NULL.
97 **/
98const char *
99gnutls_sign_get_name (gnutls_sign_algorithm_t algorithm)
100{
101 gnutls_sign_algorithm_t sign = algorithm;
102 const char *ret = NULL((void*)0);
103
104 /* avoid prefix */
105 GNUTLS_SIGN_ALG_LOOP (ret = p->name)do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if(p->id && p->id ==
sign) { ret = p->name; break; } ; } } while (0);
106
107 return ret;
108}
109
110/**
111 * gnutls_sign_list:
112 *
113 * Get a list of supported public key signature algorithms.
114 *
115 * Returns: a (0)-terminated list of #gnutls_sign_algorithm_t
116 * integers indicating the available ciphers.
117 *
118 **/
119const gnutls_sign_algorithm_t *
120gnutls_sign_list (void)
121{
122static gnutls_sign_algorithm_t supported_sign[MAX_ALGOS32] = {0};
123
124 if (supported_sign[0] == 0)
125 {
126 int i = 0;
127
128 GNUTLS_SIGN_LOOP (supported_sign[i++]=p->id)do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { supported_sign[i++]=p->id ; } }
while (0);
129 supported_sign[i++]=0;
Value stored to 'i' is never read
130 }
131
132 return supported_sign;
133}
134
135/**
136 * gnutls_sign_get_id:
137 * @name: is a MAC algorithm name
138 *
139 * The names are compared in a case insensitive way.
140 *
141 * Returns: return a #gnutls_sign_algorithm_t value corresponding to
142 * the specified cipher, or %GNUTLS_SIGN_UNKNOWN on error.
143 **/
144gnutls_sign_algorithm_t
145gnutls_sign_get_id (const char *name)
146{
147 gnutls_sign_algorithm_t ret = GNUTLS_SIGN_UNKNOWN;
148
149 GNUTLS_SIGN_LOOP (do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (strcasecmp (p->name, name) ==
0) { ret = p->id; break; } ; } } while (0)
150 if (strcasecmp (p->name, name) == 0)do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (strcasecmp (p->name, name) ==
0) { ret = p->id; break; } ; } } while (0)
151 {do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (strcasecmp (p->name, name) ==
0) { ret = p->id; break; } ; } } while (0)
152 ret = p->id;do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (strcasecmp (p->name, name) ==
0) { ret = p->id; break; } ; } } while (0)
153 break;do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (strcasecmp (p->name, name) ==
0) { ret = p->id; break; } ; } } while (0)
154 }do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (strcasecmp (p->name, name) ==
0) { ret = p->id; break; } ; } } while (0)
155 )do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (strcasecmp (p->name, name) ==
0) { ret = p->id; break; } ; } } while (0);
156
157 return ret;
158
159}
160
161gnutls_sign_algorithm_t
162_gnutls_x509_oid2sign_algorithm (const char *oid)
163{
164 gnutls_sign_algorithm_t ret = 0;
165
166 GNUTLS_SIGN_LOOP (if (p->oid && strcmp (oid, p->oid) == 0)do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (p->oid && strcmp (oid
, p->oid) == 0) { ret = p->id; break; } ; } } while (0)
167 {do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (p->oid && strcmp (oid
, p->oid) == 0) { ret = p->id; break; } ; } } while (0)
168 ret = p->id;do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (p->oid && strcmp (oid
, p->oid) == 0) { ret = p->id; break; } ; } } while (0)
169 break;do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (p->oid && strcmp (oid
, p->oid) == 0) { ret = p->id; break; } ; } } while (0)
170 }do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (p->oid && strcmp (oid
, p->oid) == 0) { ret = p->id; break; } ; } } while (0)
171 )do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (p->oid && strcmp (oid
, p->oid) == 0) { ret = p->id; break; } ; } } while (0);
172
173 if (ret == 0)
174 {
175 _gnutls_debug_log ("Unknown SIGN OID: '%s'\n", oid)do { if (__builtin_expect((_gnutls_log_level >= 2), 0)) _gnutls_log
( 2, "Unknown SIGN OID: '%s'\n", oid); } while(0);
176 return GNUTLS_SIGN_UNKNOWN;
177 }
178 return ret;
179}
180
181gnutls_sign_algorithm_t
182_gnutls_x509_pk_to_sign (gnutls_pk_algorithm_t pk, gnutls_digest_algorithm_t mac)
183{
184 gnutls_sign_algorithm_t ret = 0;
185
186 GNUTLS_SIGN_LOOP (if (pk == p->pk && mac == p->mac)do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (pk == p->pk && mac ==
p->mac) { ret = p->id; break;} ; } } while (0)
187 {do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (pk == p->pk && mac ==
p->mac) { ret = p->id; break;} ; } } while (0)
188 ret = p->id; break;}do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (pk == p->pk && mac ==
p->mac) { ret = p->id; break;} ; } } while (0)
189 )do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (pk == p->pk && mac ==
p->mac) { ret = p->id; break;} ; } } while (0);
190
191 if (ret == 0)
192 return GNUTLS_SIGN_UNKNOWN;
193 return ret;
194}
195
196const char *
197_gnutls_x509_sign_to_oid (gnutls_pk_algorithm_t pk,
198 gnutls_digest_algorithm_t mac)
199{
200 gnutls_sign_algorithm_t sign;
201 const char *ret = NULL((void*)0);
202
203 sign = _gnutls_x509_pk_to_sign (pk, mac);
204 if (sign == GNUTLS_SIGN_UNKNOWN)
205 return NULL((void*)0);
206
207 GNUTLS_SIGN_ALG_LOOP (ret = p->oid)do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if(p->id && p->id ==
sign) { ret = p->oid; break; } ; } } while (0);
208 return ret;
209}
210
211gnutls_digest_algorithm_t
212_gnutls_sign_get_hash_algorithm (gnutls_sign_algorithm_t sign)
213{
214 gnutls_digest_algorithm_t ret = GNUTLS_DIG_UNKNOWN;
215
216 GNUTLS_SIGN_ALG_LOOP (ret = p->mac)do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if(p->id && p->id ==
sign) { ret = p->mac; break; } ; } } while (0);
217
218 return ret;
219}
220
221gnutls_pk_algorithm_t
222_gnutls_sign_get_pk_algorithm (gnutls_sign_algorithm_t sign)
223{
224 gnutls_pk_algorithm_t ret = GNUTLS_PK_UNKNOWN;
225
226 GNUTLS_SIGN_ALG_LOOP (ret = p->pk)do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if(p->id && p->id ==
sign) { ret = p->pk; break; } ; } } while (0);
227
228 return ret;
229}
230
231gnutls_sign_algorithm_t
232_gnutls_tls_aid_to_sign (const sign_algorithm_st * aid)
233{
234 gnutls_sign_algorithm_t ret = GNUTLS_SIGN_UNKNOWN;
235
236 if (memcmp(aid, &unknown_tls_aid, sizeof(*aid))==0)
237 return ret;
238
239 GNUTLS_SIGN_LOOP (if (p->aid.hash_algorithm == aid->hash_algorithmdo { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (p->aid.hash_algorithm == aid
->hash_algorithm && p->aid.sign_algorithm == aid
->sign_algorithm) { ret = p->id; break; } ; } } while (
0)
240 && p->aid.sign_algorithm == aid->sign_algorithm)do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (p->aid.hash_algorithm == aid
->hash_algorithm && p->aid.sign_algorithm == aid
->sign_algorithm) { ret = p->id; break; } ; } } while (
0)
241 {do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (p->aid.hash_algorithm == aid
->hash_algorithm && p->aid.sign_algorithm == aid
->sign_algorithm) { ret = p->id; break; } ; } } while (
0)
242 ret = p->id; break;do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (p->aid.hash_algorithm == aid
->hash_algorithm && p->aid.sign_algorithm == aid
->sign_algorithm) { ret = p->id; break; } ; } } while (
0)
243 }do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (p->aid.hash_algorithm == aid
->hash_algorithm && p->aid.sign_algorithm == aid
->sign_algorithm) { ret = p->id; break; } ; } } while (
0)
244 )do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if (p->aid.hash_algorithm == aid
->hash_algorithm && p->aid.sign_algorithm == aid
->sign_algorithm) { ret = p->id; break; } ; } } while (
0);
245
246
247 return ret;
248}
249
250/* Returns NULL if a valid AID is not found
251 */
252const sign_algorithm_st*
253_gnutls_sign_to_tls_aid (gnutls_sign_algorithm_t sign)
254{
255 const sign_algorithm_st * ret = NULL((void*)0);
256
257 GNUTLS_SIGN_ALG_LOOP (ret = &p->aid)do { const gnutls_sign_entry *p; for(p = sign_algorithms; p->
name != ((void*)0); p++) { if(p->id && p->id ==
sign) { ret = &p->aid; break; } ; } } while (0);
258
259 if (ret != NULL((void*)0) && memcmp(ret, &unknown_tls_aid, sizeof(*ret))==0)
260 return NULL((void*)0);
261
262 return ret;
263}
264