Subject: [Classpathx-crypto] DOS characters in shell scripts.

From: Olivier LF <[email-masked]>
Date: Sat, 15 Jun 2002 17:46:21 +1000

Raif,

I have checkout the latest and noticed that all shell scripts and
Makefiles have the DOS end-of-line character sequence (with the extra
^M).

As a result, all the gcj tool chain was broken on Unix!
I have fixed all the files under crypto/gcj and also changed few
exe permissions for the shell scripts.
For some of the files I had to remove them from CVS altogether and re-import.

It should be working again now. 
Next time you checkout, I recommend to remove the gcj directory and 
checkout a fresh copy. Some CVS clients don't pick up the difference
between Unix and DOS ending and fail to update files correspondingly.

It is VERY important that all shell scripts and Makefiles use the Unix
ending otherwise they won't work under Unix platforms (only Cygwin
quietly filters the extra ^M)..

In fact, it would propably be better if ALL the source code had the Unix
ending, as the Primary target of the gnu project is GNU / Unix systems
rather than Windows platforms.

Olivier

PS: I'll start working on the JUnit test harness for GCJ soonish.

-- 
----------------------------------------------------------------------
Olivier Louchart-Fletcher
Email: [email-masked]

---

From: Nic Ferrier <[email-masked]>
Date: 15 Jun 2002 19:44:30 +0100

> rather than Windows platforms. 

It would certainly make life easier. However, Raif does not have a
GNU system available to him, if someone donated one, I'm sure he'd
use it.

In the mean time he's doing excellent work contributing to the
ClasspathX project.

Nic Ferrier
ClasspathX Maintainer.

---

From: "Raif S. Naffah" <[email-masked]>
Date: Sun, 16 Jun 2002 12:25:23 +1000

hello Olivier and Nic,

thanks Nic for your encouragement and support.  my comments are in-lined 
below.

> Makefiles have the DOS end-of-line character sequence (with the extra

yes you're right; i just checked them with (gVIM + Cream) --which i 
should have done instead of using that "intelligent" expensive IDE (you 
know what i'm talking about!).

i'll try to remember doing that every time i touch these files.

> As a result, all the gcj tool chain was broken on Unix!

sorry about that.

> It should be working again now.

thanks.

> Next time you checkout, I recommend to remove the gcj directory...

noted.

> rather than Windows platforms.

if you check the java sources, you'll notive that this is the case.  i 
think the tool i use wants to be too smart when it comes to (what i 
considers) plain text files.

> PS: I'll start working on the JUnit test harness for GCJ soonish.

good to hear.

cheers;
rsn

---

From: Olivier LF <[email-masked]>
Date: Sun, 16 Jun 2002 16:47:04 +1000

> thanks Nic for your encouragement and support.  my comments are in-lined 

Ooops! I am not sure if I sounded aggressive! That was not the
intention. I am very sorry, if it is the case.

> i'll try to remember doing that every time i touch these files.

One thing that is good, the cvs diff at savanah does pick up the
difference for modified files. That is if you change the content of a file
and also convert it to unix ending, the file will be fully updated.
Strangely enought, it does not work if the only change is a convertion to
Unix ending!

> considers) plain text files.

I did open a few files in the test package while working on the JUnit
compilation. Some are actually a mix up of DOS and Unix ending (most
lines with DOS ending, few with Unix).
Anyway, it does not seem to matter much for the java sources, shell
scripts and makefiles are more critical.

> >PS: I'll start working on the JUnit test harness for GCJ soonish.

It does work! I ran the test suite, it reports:

101 tests, 13 failures.

The failures are not really failures, they all seem to boil down to
java.security.Exception from requests for algorithms not available in the
gcj standard lib (as opposed to jdk).

I need to work more on the makefile before I am ready to commit the
update.

Oli

---

From: "Raif S. Naffah" <[email-masked]>
Date: Sun, 16 Jun 2002 18:22:12 +1000

Olivier LF wrote:
> ...
>> ...
> gcj standard lib (as opposed to jdk)...

the current codebase --with the gnu.crypto.jce package, which consists 
of adapters for use by the JCA/JCE-- runs fine using sun's java 
interpreter; i.e. all tests pass.  with that package, the gnu.crypto 
implements the MD5, SHA-1 (hash) and DSS (signature) that are standard 
jdk (without the need for any JCE cleanroom or otherwise add-on).

is it feasible/wothwhile for the people doing the gcj to include the 
gnu.crypto in their release?

i guess a more exhaustive list of what is failing might give us -me- a 
better clue of what is still missing.

cheers;
rsn

---

From: Nic Ferrier <[email-masked]>
Date: 16 Jun 2002 12:45:40 +0100

> know what i'm talking about!). 

A suggestion: use emacs on Windows, it does all the line ending
conversion for you.

Nic

---

From: "Raif S. Naffah" <[email-masked]>
Date: Tue, 18 Jun 2002 20:39:51 +1000

hello Nic,

> A suggestion: use emacs on Windows, it does all the line ending

i'll pass on this one.  the features that the IDE i use has, far 
outweigh the few problems that it causes.  vim is enough to help me 
show/fix line-ending problems if/when they appear.

cheers;
rsn